사람인 Android App Refactoring

open class BaseViewModel(
    private val globalErrorSubject: RxGlobalErrorSubject = RxGlobalErrorSubject
) : ViewModel(){

    protected val _progressDialogVisibilityState = PublishSubject.create<Boolean>()
    val progressDialogVisibilityState: Observable<Boolean> = _progressDialogVisibilityState.observeOn(AndroidSchedulers.mainThread())

    protected val compositeDisposable = CompositeDisposable()
    protected val networkErrorMsg = "오류가 발생했습니다.\\n새로고침 해주세요."

    fun addDisposable(disposable: Disposable) {
        compositeDisposable.add(disposable)
    }

    override fun onCleared() {
        compositeDisposable.clear()
        super.onCleared()
    }

    fun <T> Single<T>.subscribeDefault(
        consumer: Consumer<T>,
        errorConsumer: (Throwable) -> Unit,
        showProgress: Boolean = true
    ): Disposable = if (showProgress) {
        this.doOnSubscribe {
            _progressDialogVisibilityState.onNext(true)
        }.doOnEvent { _, _ ->
            _progressDialogVisibilityState.onNext(false)
        }
    } else {
        this
    }.subscribe(consumer, BaseErrorConsumer(errorConsumer))

        .
        .
        .
}

@HiltViewModel
class CategorySelectViewModel @Inject constructor(
    private val repository: CategorySelectRepository
) : BaseViewModel() {

    val companyInfoListState          = PublishSubject.create<Array<CompanyInfoListResponse>>()
    val jobCategoryResponseModelState = PublishSubject.create<JobCategoryResponseModel>()
    val jobCodeResponseModelState     = PublishSubject.create<JobCodeResponseModel>()

        .
        .
        .

    val errorState                    = PublishSubject.create<ErrorState>()

    fun getCompanyInfoList() {
        addDisposable(repository.getCompanyInfoList()
            .subscribeDefault({
                companyInfoListState.onNext(it.body() ?: arrayOf())
            },{
                errorState.onNext(ErrorState.GetCompanyInfoList(it.message!!))
            }))
    }

    fun getJobCategory() {
        addDisposable(repository.getJobCategory()
            .subscribeDefault({
                jobCategoryResponseModelState.onNext(it.body() ?: JobCategoryResponseModel())
            },{
                errorState.onNext(ErrorState.GetJobCategory(it.message!!))
            }))
    }
		
}

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        .
        .
        .

        initViewModel()
        viewModel.getJobCategory()
        .
        .
        .
    }

    private fun initViewModel() {
        compositeDisposable += viewModel.companyInfoListState.subscribe {
            i("")
            majorCompanyInfoMap = it.filter { it.comScleCd == "1" }.map { it.comNm to it.comNo }.toMap()
            midsizeCompanyInfoMap = it.filter { it.comScleCd == "2" }.map { it.comNm to it.comNo }.toMap()
            publicCompanyInfoMap = it.filter { it.comScleCd == "3" }.map { it.comNm to it.comNo }.toMap()
            binding.majorCompanyTab.performClick()
        }

        compositeDisposable += viewModel.jobCategoryResponseModelState.subscribe { model ->
            i("")
            model.data?.let { list ->
                jobCategoryMap = list.map { it!!.codeNm to it.code }.toMap()
            }
            initJobSelectView()
        }
         
        compositeDisposable += viewModel.paymentApplyState.subscribe { model ->
            i("")
            model.prdReanQty?.let {
                if (it > 0) {
                    goVideoInterviewGuideActivity()
                } else {
                    var msg   = "응시횟수가 부족합니다.\n응시횟수를 충전해 주시기 바랍니다."
                    Alert.showCustomAlert(context = this, msg = msg, confirmText = "충전하기", cancelText = "취소",
                                          confirmListener = {
                                              val purchaseListActivityIntent = Intent(this@CategorySelectActivity, PurchaseListActivity::class.java)
                                              startActivity(purchaseListActivityIntent)
                                          })
                }
            }
        }
        .
        .
        .
    }

class Car {
  private val engine = HyunDaiEngine()
  private val tire   = KHTire()
}

class Car {
  private val engine = BenzEngine()
  private val tire   = KHTire()
}

open class Engine() {

}

class HyunDaiEngine() : Engine() {

}

class Car(engine : Engine) {
  fun drive() {
      engine.drive()
  }
}

fun main() {
    val hyunDaiEngine = HyunDaiEngine() 
    val car = Car(hyunDaiEngine)
    car.drive()

    val benzEngine = BenzEngine()
    val benz = Car(benzEngine)
    benz.drive()
}

// 기존 API 인터페이스 형태, 단일 Retofit library 생성방식 
interface Api {

    @POST("/api/.../...-auth")
    fun postAppAuths(@Body parameters: HashMap<String, Any>): Single<Response<ResponseBody>>
                   
                   ........


    @POST("/api/.../..../...-preview-connect")
    fun putConnect(
            @Header("Authorization") authorization: String,
            @Body parameters: HashMap<String, Any>)
            : Single<Response<ResponseBody>>

}


class RetroApi {

    companion object {

        private fun defaultRetrofit(): Retrofit {
            return Retrofit.Builder()
                    .baseUrl(App.getInstance().gPref.baseServer)
                    .addConverterFactory(GsonConverterFactory.create())
                    .addCallAdapterFactory(RxJava2CallAdapterFactory.create())
                    .client(createOkHttpClient())
                    .build()
        }


        fun create(): Api {
            return defaultRetrofit().create(Api::class.java)
        }

        .
        .
        .
    }
}

@Module
@InstallIn(SingletonComponent::class)
class ApplicationModule {

    @Provides
    @Singleton
    fun provideRetrofit(okHttpClient: OkHttpClient): Retrofit {
        return Retrofit.Builder()
            .baseUrl(App.getInstance().gPref.baseServer)
            .addConverterFactory(NullOnEmptyConverterFactory())
            .addConverterFactory(GsonConverterFactory.create())
            .addCallAdapterFactory(LiveDataCallAdapterFactory())
            .addCallAdapterFactory(RxJava3CallAdapterFactory.createSynchronous())
            .client(okHttpClient)
            .build()
    }

    @Provides
    @Singleton
    fun provideOkHttpClient(headerInterceptor: Interceptor): OkHttpClient {
        val interceptor = HttpLoggingInterceptor()

        if (App.getInstance().gPref.isDebug) {
            interceptor.level = HttpLoggingInterceptor.Level.BODY
        } else {
            interceptor.level = HttpLoggingInterceptor.Level.NONE
        }

        return OkHttpClient.Builder()
            .addNetworkInterceptor(interceptor)
            .addNetworkInterceptor(StethoInterceptor())
            .addInterceptor(headerInterceptor)
            .build()
    }

        .
        .
        .

    @Provides
    @Singleton
    fun providePreferences() : PreferencesInterface = App.getInstance().gPref

    @Provides
    @Singleton
    fun provideCommonApis(retrofit: Retrofit) : CommonAPIs       = retrofit.create(CommonAPIs::class.java)

    @Provides
    @Singleton
    fun provideAppStartApis(retrofit: Retrofit) : AppStartAPIs   = retrofit.create(AppStartAPIs::class.java)

    @Provides
    @Singleton
    fun provideMessageDatabase(@ApplicationContext context: Context): MessageDatabase = MessageDatabase.getInstance(context)

    @Provides
    @Singleton
    fun provideMessageDao(db: MessageDatabase) : MessageDao = db.messageDao()

    @Provides
    @Singleton
    fun provideMessageLocalRepository(dao: MessageDao) : MessageLocalRepository = MessageLocalRepository(dao)

    @Provides
    @Singleton
    fun provideSocketManager() : SocketManager = SocketManager()
        .
        .
        .
}

@AndroidEntryPoint
class CategorySelectActivity : BaseActivity<ActivityCategorySelectBinding>(), View.OnTouchListener {

    private val viewModel: CategorySelectViewModel by viewModels()

    override val layoutResID: Int = R.layout.activity_category_select
    override val color: Int       = R.color.white

    private var itvTpCd     = ""   
    private var crerStCd    = ""   
    private var jobCategory = ""    
    private var octpCd      = "" 
        .
        .
        .
}

@HiltViewModel
class CategorySelectViewModel @Inject constructor(
    private val repository: CategorySelectRepository
) : BaseViewModel() {

    val companyInfoListState          = PublishSubject.create<Array<CompanyInfoListResponse>>()
    val jobCategoryResponseModelState = PublishSubject.create<JobCategoryResponseModel>()
    val jobCodeResponseModelState     = PublishSubject.create<JobCodeResponseModel>()
    val partnershipState              = PublishSubject.create<PartnershipCertifyInfoResponseModel>()
    val paymentApplyState             = PublishSubject.create<PaymentApplyResponseModel>()
    val errorState                    = PublishSubject.create<ErrorState>()

    fun getCompanyInfoList() {
        addDisposable(repository.getCompanyInfoList()
            .subscribeDefault({
                companyInfoListState.onNext(it.body() ?: arrayOf())
            },{
                errorState.onNext(ErrorState.GetCompanyInfoList(it.message!!))
            }))
    }
        .
        .
        .
}

class CategorySelectRepository @Inject constructor(
        private val api         : CategorySelectApi,
        private val commonApi   : CommonAPIs,
        private val pref        : PreferencesInterface = App.getInstance().gPref
) : CommonRepository(api = commonApi, pref = pref) {

        fun getCompanyInfoList(): Single<Response<Array<CompanyInfoListResponse>>> {
                return execute(api.getCompanyInfoList())
                        .subscribeOn(Schedulers.io())
                        .observeOn(AndroidSchedulers.mainThread())
        }

        fun getJobCategory(): Single<Response<JobCategoryResponseModel>> {
                return execute(api.getJobCategory())
                        .subscribeOn(Schedulers.io())
                        .observeOn(AndroidSchedulers.mainThread())
        }

        .
        .
        . 
}

//xml파일 activity_main.xml
<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    tools:context=".ui.mypage.profile.ProfileActivity">

    <androidx.constraintlayout.widget.ConstraintLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:background="#fff"
        android:fitsSystemWindows="true">

            <TextView
                android:id="@+id/tvName"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                tools:text="테스트" />

    </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

class MainActivity : AppCompatActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)

        //과거 방식
        findViewById<TextView>(R.id.tvName).text = "Hi"
        //리팩토링 전방식 android-extension라이브러리 사용 
        //class상단 import kotlinx.android.synthetic.main.activity_main.*
        //xml id직접연결가능 tvName이 다른화면의 activity_sample등 다른xml에 존재시
        //연결할수 있음 대신 구동시 런타임에러가 나타남.
        tvName.text= "Hi"
        
    }
        .
        .
        .
}

abstract class BaseAppCompatActivity<T: ViewDataBinding>: AppCompatActivity() {
    lateinit var binding: T
    abstract val layoutResID : Int

        .
        .
        .
    
    override fun onCreate(savedInstanceState: Bundle?, persistentState: PersistableBundle?) {
        super.onCreate(savedInstanceState, persistentState)
        onWindowFocusChanged(true)
        setBinding()
    }

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        window.allowEnterTransitionOverlap = true
        onWindowFocusChanged(true)
        setBinding()
    }

    private fun setBinding() {
        binding = DataBindingUtil.setContentView(this, layoutResID)
        binding.lifecycleOwner = this@BaseAppCompatActivity

        .
        .
        .
    }
}

@AndroidEntryPoint
class ChatRoomActivity : BaseAppCompatActivity<ActivityChatRoomBinding>() {

    override val layoutResID = R.layout.activity_chat_room

    private val  viewModel: ChatRoomViewModel by viewModels()
    lateinit var adapter: ChatRoomAdapter
    
        .
        .
        .
  
    override fun onCreate(savedInstanceState: Bundle?) {
        .
        .
        .
        binding.lifecycleOwner = this
        binding.viewModel = this.viewModel
    }
}